Review and improve mobile app plan: fix critical gaps#922
Open
marcodejongh wants to merge 3 commits intomainfrom
Open
Review and improve mobile app plan: fix critical gaps#922marcodejongh wants to merge 3 commits intomainfrom
marcodejongh wants to merge 3 commits intomainfrom
Conversation
Adversarial review of the Capacitor mobile plan identified 14 issues across critical, high, and medium severity. Key changes: - Add Capacitor bridge injection strategy for hosted mode - Add authentication/cookie persistence section for WebView - Fix BLE double-chunking bug (adapter owns all transport chunking) - Expand BluetoothAdapter interface (isAvailable, MTU, unsubscribe) - Add development workflow section (local dev, debugging, device matrix) - Add "Why Not Local/Bundled Mode" rationale (app is too server-dependent) - Scope deep links to specific paths, not entire domain - Add offline fallback with @capacitor/network plugin - Reorder milestones: App Store before Push Notifications - Defer push notifications to post-launch v1.1 - Update timeline from 5-6 weeks to 10-13 weeks realistic estimate - Fix KeepAwake version mismatch (^5.0.0 -> ^6.0.0) - Add native Sentry for crash reporting outside WebView - Upgrade App Store rejection risk from Medium to High with mitigations https://claude.ai/code/session_01WvCyzNPbY81tozSyFSEWpT
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Claude Review✅ Ready to merge - No significant issues found. This is a documentation-only PR updating the mobile app plan with no code changes. The improvements address legitimate concerns including:
No issues to report. |
Instead of relying entirely on the server for climb data, bundle a per-board SQLite database in the native app. This provides: - Offline climb search and browsing without internet - Stronger App Store approval case (genuine native functionality) - Faster search (no network latency, local SQLite queries) Key design decisions: - Per-board databases delivered via On-Demand Resources (iOS) and Play Asset Delivery (Android) to keep initial download small (~15 MB) - Each board's data is ~100-150 MB compressed - Read-only reference data only; user-specific data stays server-side - Delta sync on app launch keeps data current - New Milestone 1.5 adds 2 weeks to timeline (12-15 weeks total) - Added @capacitor-community/sqlite to dependencies https://claude.ai/code/session_01WvCyzNPbY81tozSyFSEWpT
Claude Review✅ Ready to merge - Minor issue noted below, but nothing blocking. Minor issue:
|
- Document that Aurora's Kilter/Tension data originates from SQLite databases in their APKs — the export pipeline reverses the existing import flow - Note unified table design with board_type discriminator column - Add concrete PostgreSQL → SQLite export script with per-board filtering and CSV import - Add mobile-specific SQLite indexes for search performance: - Composite index on search WHERE clause columns - Edge filtering index for size boundaries - Stats lookup index for JOIN + sort - Difficulty range, name search, and setter indexes - Downgrade App Store rejection risk from High to Medium given the stronger native value proposition (offline DB + BLE) https://claude.ai/code/session_01WvCyzNPbY81tozSyFSEWpT
Claude Review✅ Ready to merge - Documentation-only PR with no code changes. The mobile app plan updates are comprehensive and well-structured. No issues found. This is a planning document that improves the mobile app strategy with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial review of the Capacitor mobile plan identified 14 issues across critical, high, and medium severity. Key changes:
https://claude.ai/code/session_01WvCyzNPbY81tozSyFSEWpT