Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to restore/improve MarkLogic crash stack trace generation for the (root) UBI-based images by ensuring required debugger/runtime dependencies remain in the image, and by documenting the required container capability (SYS_PTRACE) in the README.
Changes:
- Stop removing Python-related packages in the
marklogic-server-ubiimage cleanup step so debugger stack traces can be generated. - Expand UBI8/UBI9 dependency images to explicitly install
gdb-related runtime dependencies. - Update README examples and add a new section describing how to enable stack trace generation via
--cap-add=SYS_PTRACE.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| dockerFiles/marklogic-server-ubi:base | Keeps Python/gdb dependencies by trimming the “remove optional packages” list. |
| dockerFiles/marklogic-deps-ubi:base | Installs additional packages (e.g., Python/procps/libcap) to support gdb stack traces on UBI8. |
| dockerFiles/marklogic-deps-ubi9:base | Installs additional packages to support gdb stack traces on UBI9. |
| README.md | Documents stack trace enablement and adds SYS_PTRACE capability to many examples. |
You can also share your feedback on Copilot code review. Take the survey.
vitalykorolev
left a comment
There was a problem hiding this comment.
Looks good, but I have a small concern regarding the basic docker-run examples. Maybe we can check with PO on this.
vitalykorolev
left a comment
There was a problem hiding this comment.
We need to make sure the pipeline is green before the merge.
|
Looks good to me. We can wait for pipeline to be green and merge |
Description
Checklist:
Owner:
JIRA_ID as part of branch/PR name
Rebase the branch with upstream
Squashed all commits into a single commit
Added Tests
Reviewer:
Reviewed Tests
Added to Release Wiki/Jira