Skip to content

PDP-981 : Update copyrightcheck.py for multiline exclude list#39

Open
brijeshp56 wants to merge 14 commits intomainfrom
brijesh-PDP-981
Open

PDP-981 : Update copyrightcheck.py for multiline exclude list#39
brijeshp56 wants to merge 14 commits intomainfrom
brijesh-PDP-981

Conversation

@brijeshp56
Copy link
Collaborator

@brijeshp56 brijeshp56 commented Mar 26, 2026

Updated code to support both single line and multi line exclude list. Test below scenarios:

  1. Two files without copyright information added and flagged by workflow. https://github.com/brijeshp56/copyrighttest/pull/34
  2. Single line exclusion list:https://github.com/brijeshp56/copyrighttest/pull/35
  3. Multiline exclusion list: https://github.com/brijeshp56/copyrighttest/pull/36
  4. Multiline exclusion list where filesexcluded: doesn't have exclusion list to its right: https://github.com/brijeshp56/copyrighttest/pull/37

Updated code to support both single line and multi line exclude list.
Copilot AI review requested due to automatic review settings March 26, 2026 06:34
@brijeshp56 brijeshp56 self-assigned this Mar 26, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the copyrightcheck.py configuration parser to support filesexcluded values specified either on a single line (comma-separated) or as a multi-line list, improving flexibility of the script’s exclude configuration.

Changes:

  • Add support for multi-line filesexcluded: blocks in the plain-text config parser.
  • Refactor config parsing flow to separately handle empty lines vs. comment lines and track an “active” multi-line key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ines

Update copyrightcheck.py to have exclude file in multiple lines
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update copyrightcheck.py
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

brijeshp56 and others added 2 commits March 26, 2026 21:34
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Mar 26, 2026

@brijeshp56 I've opened a new pull request, #40, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits March 26, 2026 16:05
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Mar 26, 2026

@brijeshp56 I've opened a new pull request, #41, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 4 commits March 26, 2026 16:06
Agent-Logs-Url: https://github.com/marklogic/pr-workflows/sessions/8161bf32-06e4-47c5-b637-c6c6e1ca0037

Co-authored-by: brijeshp56 <203762578+brijeshp56@users.noreply.github.com>
PDP-981 : Remove trailing whitespace in copyrightcheck.py
PDP-981 : Remove trailing whitespace in copyrightcheck.py line 315
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants