Support Vue/Alpine attribute shorthand syntax#42
Open
CasualX wants to merge 1 commit intomathiversen:masterfrom
Open
Support Vue/Alpine attribute shorthand syntax#42CasualX wants to merge 1 commit intomathiversen:masterfrom
CasualX wants to merge 1 commit intomathiversen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows attribute names to start with
@and:, so templates using Vue/Alpine-style shorthand can be parsed without failing.Examples this enables:
@click="handler":class="classes":disabled="isDisabled"Without this patch the elements are returned as text nodes.
I understand this crate is an HTML parser rather than framework-specific template syntax, so I wanted to check whether you'd be open to this kind of support upstream.
This PR only broadens accepted attribute key syntax. It does not add any framework-specific behavior or interpretation; it simply preserves these attributes in the parsed DOM while making the parser usable for real-world template syntax.
Browsers already accept these attribute names as ordinary attributes even when no framework runtime is present. I understand this raises the question whether it is better to support only
@/:shorthands or to more broadly align attribute syntax accepted by browser HTML parsers, I would be happy to adjust the implementation accordingly!