Open
Conversation
The API returns HTML instead of JSON for 404 responses
for nonexistent endpoints
(e.g. `GET "/networks/{networkId}/appliance/firewall/multicastForwarding"`).
`meraki.rest_session.RestSession` raises an `APIError`
with `.status = 404`
and `message` set to the first few bytes of the HTML
and `"please wait a minute if the key or org was just newly created."` appended:
`"<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtmplease wait a minute if the key or org was just newly created."`.
`meraki.aio.rest_session.AsyncRestSession`
instead tries to parse the message as JSON
and does not handle the resulting `JSONDecodeError`.
That exception does not include the status code so it's not useful.
Fix the typo in handling JSON decode errors for 4xx responses.
AsyncRestSession: Fix handling JSONDecodeError for 404
- Bump version to 2.2.0 in pyproject.toml and __init__.py. - Update API documentation for AsyncAppliance and AsyncOrganizations to clarify port settings and add new methods for connecting and disconnecting Cisco Umbrella accounts. - Adjust maximum lookback periods and pagination limits in various API methods for improved functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.