You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
align the SX1262 reset wiring with Heltec's published V3 board mapping
leave the rest of the Heltec V3 configuration unchanged
Why this is the right fix
Heltec's WiFi LoRa 32 V3 pin map and datasheet both document the SX1262 reset line on GPIO12 as LoRa_RST. MeshCore already passes P_LORA_RESET into the Heltec V3 radio Module constructor, so defining that pin as disconnected was inconsistent with the published hardware wiring.
Setting P_LORA_RESET to 12 matches the vendor mapping already used by the closely related Heltec V4 variant and corrects the V3 board definition without changing any other board behavior.
Looking through the history, this also seems justified.
The incorrect value was introduced in c4a2b139 ("moved HeltecV3Board.h to variant folder"), where variants/heltec_v3/platformio.ini gained an explicit P_LORA_RESET=RADIOLIB_NC while the rest of the SX1262 pin block was already the documented Heltec layout (DIO1=14, NSS=8, BUSY=13, SCK=9, MISO=11, MOSI=10). I checked the subsequent history and did not find any commit or PR discussion explaining why V3 should intentionally ignore a wired reset line.
That makes this PR look like a straightforward board-definition correction. Heltec's published WiFi LoRa 32 V3 pin map and datasheet show LoRa_RST on GPIO12, and the target code already passes P_LORA_RESET into the SX1262 Module constructor, so using 12 here is consistent with both the vendor docs and the existing driver wiring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is the right fix
Heltec's WiFi LoRa 32 V3 pin map and datasheet both document the SX1262 reset line on GPIO12 as LoRa_RST. MeshCore already passes P_LORA_RESET into the Heltec V3 radio Module constructor, so defining that pin as disconnected was inconsistent with the published hardware wiring.
Setting P_LORA_RESET to 12 matches the vendor mapping already used by the closely related Heltec V4 variant and corrects the V3 board definition without changing any other board behavior.
Authoritative sources:
Validation