You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
stop advertising a separate GPS enable pin that is not documented for this board
Why this is the right fix
Heltec's Wireless Tracker documentation identifies GPIO35 as GNSS_RST and GPIO36 as PPS. The current variant defined GPIO35 as PIN_GPS_EN and GPIO36 as PIN_GPS_RESET, which inverted the documented control lines and omitted the PPS signal entirely.
This change moves PIN_GPS_RESET to 35, adds PIN_GPS_PPS on 36, and removes the undocumented dedicated GPS enable pin from the variant. That keeps the board definition aligned with the vendor pin map and matches how this target already shares peripheral power through PIN_VEXT_EN.
Looking through the history, this one also appears justified.
The incorrect GPS control mapping was introduced in 59d9770a ("Add GPS support Heltec Wireless Tracker v1.x"). That commit set PIN_GPS_EN=35, PIN_GPS_RESET=36, and added the matching comment in variants/heltec_tracker/target.cpp describing GPIO35 as enable and GPIO36 as reset. I went back through the later history and did not find any follow-up discussion or correction that would justify treating those pins that way.
What makes this a strong fix is that the same commit appears to have simply misread the Heltec board docs: the official tracker pinout labels GPIO35 as GNSS_RST and GPIO36 as PPS. So this PR is not changing established intended behavior so much as correcting the original board-definition interpretation and exposing the documented PPS line that was previously omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is the right fix
Heltec's Wireless Tracker documentation identifies GPIO35 as GNSS_RST and GPIO36 as PPS. The current variant defined GPIO35 as PIN_GPS_EN and GPIO36 as PIN_GPS_RESET, which inverted the documented control lines and omitted the PPS signal entirely.
This change moves PIN_GPS_RESET to 35, adds PIN_GPS_PPS on 36, and removes the undocumented dedicated GPS enable pin from the variant. That keeps the board definition aligned with the vendor pin map and matches how this target already shares peripheral power through PIN_VEXT_EN.
Authoritative source:
Validation