Separate RadioLib ISR events from main radio mode#2062
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
Separate RadioLib ISR events from main radio mode#2062robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the RadioLib wrapper ISR handoff by separating interrupt events from the main radio mode state.
Problem
RadioLibWrappercurrently shares a singlevolatile uint8_t statebetween ISR and normal code:state |= STATE_INT_READYstate = STATE_IDLE,state = STATE_RX, andstate = STATE_TX_WAITThat is not an atomic synchronization scheme.
volatileonly prevents caching; it does not make read-modify-write operations safe. An interrupt can arrive between the load and store of one of those assignments, causing a completion event to be lost.That can show up as missed send-complete / receive-complete notifications and inconsistent mode transitions.
Fix
This PR removes the overloaded shared state byte and splits the responsibilities:
radio_modeis now main-context only and tracksIDLE,RX, orTX_WAITpending_interrupt_eventsis ISR-owned and only records completion eventsThe wrapper now reasons about:
radio_modeinstead of trying to encode both into one shared variable.
Why this fixes it
Main code no longer overwrites an ISR-owned bitfield. The ISR publishes completion events into its own channel, and the main loop claims them explicitly before acting.
That removes the lost-interrupt window that existed when the code mixed plain assignments and ISR-side bit-setting on the same byte.
Validation
Built successfully:
Heltec_v3_repeater