Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T1000eBoard::buttonStateChanged()respectUSER_BTN_PRESSEDIssue
The T1000-E board definition already declares the user button as active-high in:
variants/t1000-e/platformio.ini-D USER_BTN_PRESSED=HIGHBut
T1000eBoard::buttonStateChanged()still hardcodesLOWas the pressed state.That leaves the board helper out of sync with the actual board configuration. Even if most T1000-E UI paths currently use the generic button abstraction instead of this helper, keeping the helper inverted is still a maintenance trap for any code that uses the board class directly.
Fix
This change:
USER_BTN_PRESSEDfallback used elsewhere in the UI codeLOWcomparison inbuttonStateChanged()withUSER_BTN_PRESSEDWhy this fixes it
It makes the board helper follow the same polarity source as the rest of the T1000-E build. That keeps the T1000-E board abstraction internally consistent and avoids future regressions where direct board-button callers would interpret presses backwards.
Validation
pio run -e t1000e_companion_radio_ble