fix: add missing #include <chrono> for Windows ARM64 build#446
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: add missing #include <chrono> for Windows ARM64 build#446Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
In setup_env.py (line 107) and utils/e2e_benchmark.py (line 23), the sys.exit(1) was at the same indentation level as 'try', causing it to run unconditionally after subprocess completes - even when the command succeeds. This moves sys.exit(1) inside the except block where it belongs. Fixes: microsoft#447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing
#include <chrono>tocommon/common.cppandcommon/log.cppin the llama.cpp submodule to fix the Windows ARM64 (Snapdragon X Elite) build.Problem
The Windows ARM64 build fails with errors:
error: no type named 'system_clock' in namespace 'std::chrono'error: 'clock' is not a class, namespace, or enumerationOn Linux/Mac,
<chrono>is pulled in transitively through<thread>. On Windows with ClangCL, this transitive include doesnt work, requiring an explicit include.Fix
Added
#include <chrono>to both files:3rdparty/llama.cpp/common/common.cpp3rdparty/llama.cpp/common/log.cppTesting
This fix is based on the analysis in issue #440 which documents the complete Windows ARM64 build requirements for Snapdragon X Elite.
Fixes issue #440