fix: move sys.exit(1) inside except block in run_command#450
Open
Jah-yee wants to merge 3 commits intomicrosoft:mainfrom
Open
fix: move sys.exit(1) inside except block in run_command#450Jah-yee wants to merge 3 commits intomicrosoft:mainfrom
Jah-yee wants to merge 3 commits intomicrosoft:mainfrom
Conversation
- Enables running BitNet in Kubernetes or Docker environments - Uses Python 3.11-slim as base image - Installs all build dependencies (cmake, build-essential) - Includes Python requirements for inference - Resolves: microsoft#433
The sys.exit(1) was at wrong indentation level - same as try block instead of inside except block. This caused the function to always exit with code 1 after running any command, even on success. Fixes: setup_env.py line 107, utils/e2e_benchmark.py line 23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sys.exit(1) was at wrong indentation level - same as try block instead of inside except block. This caused the function to always exit with code 1 after running any command, even on success.
Fixes: setup_env.py line 107, utils/e2e_benchmark.py line 23
See issue: #447