Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions CI workflow to standardize which optional Rust features are exercised in CI and to expand lint coverage across configurations.
Changes:
- Introduces a
DISKANN_FEATURESenv var to centralize the explicit feature set used for “all-features”-style checks. - Adds a new
clippy-featuresjob to runcargo clippywith the explicit feature set. - Adjusts
Swatinem/rust-cacheconfiguration to useshared-keyfor several jobs and reusesDISKANN_FEATURESfor the feature-enabled test job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
harsha-simhadri
approved these changes
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 89.10% 89.28% +0.18%
==========================================
Files 443 442 -1
Lines 83361 83009 -352
==========================================
- Hits 74277 74113 -164
+ Misses 9084 8896 -188
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
metajack
requested changes
Mar 17, 2026
added 7 commits
March 17, 2026 14:20
Contributor
Author
|
Thanks @metajack - I learned way more than I anticipated about how the CI cache works. |
metajack
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform the following CI chores:
clippyand include thedisk-indexfeature fordiskann-benchmark.-Dwarningsexplicitly to the clippy jobs. Previously, this wasn't being propagated frombuild.rustflags, meaning that clippy lints weren't blocking check-in.no-default-featurestests to execute serially instead of as multiple jobs. This reduces the CI cache used for this job from ~850 MB for the 9 tested crates to around 160 MB. The job takes a little longer, but still under 1 minute.Finally, since clippy now correctly respects
-Dwarnings, there were two lints that needed fixing: one invalid conversion, and one regarding the disallowed overlay method (which doesn't exist when default features are disabled).