Skip to content

CI maintenance#838

Merged
hildebrandmw merged 10 commits intomainfrom
mhildebr/clippy-with-features
Mar 18, 2026
Merged

CI maintenance#838
hildebrandmw merged 10 commits intomainfrom
mhildebr/clippy-with-features

Conversation

@hildebrandmw
Copy link
Contributor

@hildebrandmw hildebrandmw commented Mar 16, 2026

Perform the following CI chores:

  • Add feature tests to clippy and include the disk-index feature for diskann-benchmark.
  • Pass -Dwarnings explicitly to the clippy jobs. Previously, this wasn't being propagated from build.rustflags, meaning that clippy lints weren't blocking check-in.
  • Rewrite the no-default-features tests to execute serially instead of as multiple jobs. This reduces the CI cache used for this job from ~850 MB for the 9 tested crates to around 160 MB. The job takes a little longer, but still under 1 minute.

Finally, since clippy now correctly respects -Dwarnings, there were two lints that needed fixing: one invalid conversion, and one regarding the disallowed overlay method (which doesn't exist when default features are disabled).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflow to standardize which optional Rust features are exercised in CI and to expand lint coverage across configurations.

Changes:

  • Introduces a DISKANN_FEATURES env var to centralize the explicit feature set used for “all-features”-style checks.
  • Adds a new clippy-features job to run cargo clippy with the explicit feature set.
  • Adjusts Swatinem/rust-cache configuration to use shared-key for several jobs and reuses DISKANN_FEATURES for the feature-enabled test job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@harsha-simhadri harsha-simhadri linked an issue Mar 16, 2026 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.28%. Comparing base (72fc467) to head (d4fa355).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   89.10%   89.28%   +0.18%     
==========================================
  Files         443      442       -1     
  Lines       83361    83009     -352     
==========================================
- Hits        74277    74113     -164     
+ Misses       9084     8896     -188     
Flag Coverage Δ
miri 89.28% <ø> (+0.18%) ⬆️
unittests 89.12% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-tools/src/utils/search_disk_index.rs 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw
Copy link
Contributor Author

Thanks @metajack - I learned way more than I anticipated about how the CI cache works.

@hildebrandmw hildebrandmw merged commit d8ac3a1 into main Mar 18, 2026
22 checks passed
@hildebrandmw hildebrandmw deleted the mhildebr/clippy-with-features branch March 18, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] No gates for disk-index feature

5 participants