Add PowerShell version of RunFunctionalTests-Dev#1920
Merged
tyrielv merged 2 commits intomicrosoft:masterfrom Mar 25, 2026
Merged
Add PowerShell version of RunFunctionalTests-Dev#1920tyrielv merged 2 commits intomicrosoft:masterfrom
tyrielv merged 2 commits intomicrosoft:masterfrom
Conversation
KeithIsSleeping
left a comment
KeithIsSleeping
left a comment
There was a problem hiding this comment.
Multi-Model Code Review
Reviewed with Claude Opus 4.6, GPT-5.1-Codex-Max, and GPT-5.4. Finding below is a consensus item where multiple models independently identified the same issue.
KeithIsSleeping
left a comment
KeithIsSleeping
left a comment
There was a problem hiding this comment.
Additional finding from GPT-5.3-Codex review.
RunFunctionalTests-Dev.ps1 replaces the bat script as the preferred way to run functional tests in dev mode. Improvements over the bat script: - Derives a unique test service name per enlistment (hash of path), so concurrent test runs from different working directories use separate named pipes and don't interfere with each other. - Isolates test data directories per enlistment. - After the test process exits, cleans up only GVFS.Service.exe processes whose ParentProcessId matches the test runner PID — safe for concurrent runs and never touches the real Windows service. The C# change makes TestServiceName read from GVFS_TEST_SERVICE_NAME env var, falling back to the original hardcoded value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tyrielv
force-pushed
the
tyrielv/fix-dev-test-cleanup
branch
from
2a68695 to
544c4ac
Compare
KeithIsSleeping
approved these changes
Mar 24, 2026
KeithIsSleeping
left a comment
KeithIsSleeping
left a comment
There was a problem hiding this comment.
All feedback addressed: per-run isolation via PID suffix in service name and data dirs, empty env var handled with IsNullOrWhiteSpace. LGTM.
…tyrielv/fix-dev-test-cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunFunctionalTests-Dev.ps1 replaces the bat script as the preferred way to run functional tests in dev mode. Improvements over the bat script:
The C# change makes TestServiceName read from GVFS_TEST_SERVICE_NAME env var, falling back to the original hardcoded value.