Skip to content

ci: revert RUSTFLAGS env var leak workaround in build.yaml#60

Draft
Copilot wants to merge 1 commit intomainfrom
copilot/revert-rustflags-leak-workaround
Draft

ci: revert RUSTFLAGS env var leak workaround in build.yaml#60
Copilot wants to merge 1 commit intomainfrom
copilot/revert-rustflags-leak-workaround

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 28, 2026

Summary

Reverts the temporary RUSTFLAGS environment variable workaround in the cargo make build step of .github/workflows/build.yaml.

Changes

Removed:

  • The $env:RUSTFLAGS = $null line that unset RUSTFLAGS before running cargo make
  • The associated comment explaining the workaround
  • The shell: pwsh directive (no longer needed with a single-line run)

Restored the step to a simple single-line command:

run: cargo make default +${{ matrix.rust_toolchain }} --locked --profile ${{ matrix.cargo_profile }} --target ${{ matrix.target_triple.name }}

Context

The workaround was introduced in #49 to prevent RUSTFLAGS (specifically -D warnings) from leaking into rust-script compilation of wdk-build (a path dependency via symlink that defeats --cap-lints). The upstream fix is tracked at microsoft/windows-drivers-rs#629.

Copilot AI requested a review from wmmc88 March 28, 2026 00:38
@wmmc88 wmmc88 changed the title Revert RUSTFLAGS env var leak workaround in build.yaml ci: Revert RUSTFLAGS env var leak workaround in build.yaml Mar 30, 2026
@wmmc88 wmmc88 changed the title ci: Revert RUSTFLAGS env var leak workaround in build.yaml ci: revert RUSTFLAGS env var leak workaround in build.yaml Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants