Skip to content

fix: fix parameters in deployment templates to match bicep file#453

Open
Harsh-Microsoft wants to merge 1 commit intodevfrom
hb-psl-us-37608
Open

fix: fix parameters in deployment templates to match bicep file#453
Harsh-Microsoft wants to merge 1 commit intodevfrom
hb-psl-us-37608

Conversation

@Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request updates documentation and infrastructure templates to improve parameter clarity, support WAF-aligned deployments, and ensure compatibility with the latest Bicep tooling. The most significant changes are the addition of new parameters for WAF deployments, updates to parameter naming and allowed values, and a Bicep version upgrade across infrastructure files.

Documentation and Parameter Updates:

  • Added new documentation for WAF deployment parameters in docs/CustomizingAzdParameters.md, including AZURE_ENV_VM_SIZE, AZURE_ENV_VM_ADMIN_USERNAME, and AZURE_ENV_VM_ADMIN_PASSWORD. Also clarified and updated existing parameter descriptions and allowed values, and renamed or replaced some parameters for consistency.
  • Updated WAF parameter names in infra/main.waf.parameters.json to match new documentation and environment variable naming conventions (vmSize, vmAdminUsername, vmAdminPassword).

Infrastructure and Tooling Updates:

  • Upgraded Bicep generator version from 0.40.2.10011 to 0.41.2.15936 in multiple sections of infra/main.json, resulting in new template hashes throughout the file [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12].
  • Corrected resource dependency ordering in infra/main.json for private DNS zones to ensure proper deployment sequencing.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant