fix: fix parameters in deployment templates to match bicep file#453
Open
Harsh-Microsoft wants to merge 1 commit intodevfrom
Open
fix: fix parameters in deployment templates to match bicep file#453Harsh-Microsoft wants to merge 1 commit intodevfrom
Harsh-Microsoft wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates documentation and infrastructure templates to improve parameter clarity, support WAF-aligned deployments, and ensure compatibility with the latest Bicep tooling. The most significant changes are the addition of new parameters for WAF deployments, updates to parameter naming and allowed values, and a Bicep version upgrade across infrastructure files.
Documentation and Parameter Updates:
docs/CustomizingAzdParameters.md, includingAZURE_ENV_VM_SIZE,AZURE_ENV_VM_ADMIN_USERNAME, andAZURE_ENV_VM_ADMIN_PASSWORD. Also clarified and updated existing parameter descriptions and allowed values, and renamed or replaced some parameters for consistency.infra/main.waf.parameters.jsonto match new documentation and environment variable naming conventions (vmSize,vmAdminUsername,vmAdminPassword).Infrastructure and Tooling Updates:
0.40.2.10011to0.41.2.15936in multiple sections ofinfra/main.json, resulting in new template hashes throughout the file [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12].infra/main.jsonfor private DNS zones to ensure proper deployment sequencing.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information