Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for orchestration “tags” in the SQL Server provider, including schema/storage, parameter plumbing, and validation via new unit/integration tests.
Changes:
- Persist tags in SQL by adding an
Instances.Tagscolumn and wiring stored procedures to read/write it. - Plumb tag serialization/deserialization into
SqlUtilsand pass tags intoCreateInstance/_CheckpointOrchestration. - Add unit + integration test coverage for tags (including backward-compat behavior when tags aren’t set).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DurableTask.SqlServer.Tests/Utils/TestService.cs | Adds a helper for starting orchestrations with tags in integration tests. |
| test/DurableTask.SqlServer.Tests/Unit/SqlUtilsTagTests.cs | New unit tests for AddTagsParameter serialization/null handling. |
| test/DurableTask.SqlServer.Tests/Integration/Orchestrations.cs | Adds integration tests validating tags behavior (set, empty, ContinueAsNew, etc.). |
| test/DurableTask.SqlServer.Tests/Integration/DatabaseManagement.cs | Updates expected schema script list to include schema-1.3.0.sql. |
| test/DurableTask.SqlServer.AzureFunctions.Tests/DurableTask.SqlServer.AzureFunctions.Tests.csproj | Changes test target framework to net8.0. |
| src/DurableTask.SqlServer/SqlUtils.cs | Adds tag read/write helpers and populates Tags on returned state/events. |
| src/DurableTask.SqlServer/SqlOrchestrationService.cs | Passes tags into relevant stored procedure calls. |
| src/DurableTask.SqlServer/Scripts/schema-1.3.0.sql | Adds Tags column to the Instances table. |
| src/DurableTask.SqlServer/Scripts/logic.sql | Extends sprocs/selects to accept/store/return tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...DurableTask.SqlServer.AzureFunctions.Tests/DurableTask.SqlServer.AzureFunctions.Tests.csproj
Outdated
Show resolved
Hide resolved
fanyirobin
force-pushed
the
dev/yifan1/tags
branch
from
3638da5 to
336173b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgillum
reviewed
Mar 2, 2026
test cleanup rollback .net version change for tets
address comments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lServer.AzureFunctions.Tests.csproj address comments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
address copilot comment. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
address comment Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fanyirobin
force-pushed
the
dev/yifan1/tags
branch
from
6524a22 to
ef8b2ba
Compare
… handle tag non exist when GetTags is called
cgillum
reviewed
Mar 11, 2026
cgillum
approved these changes
Mar 11, 2026
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your patience on this PR.
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.