Include package in JUnit test names#2207
Merged
dagood merged 1 commit intomicrosoft/mainfrom Mar 24, 2026
Merged
Conversation
gdams
approved these changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the eng/_util test JSON → JUnit conversion to emit fully-qualified (package-included) test names, aligning CI JUnit output with the follow-up behavior requested from microsoft/go-infra#445.
Changes:
- Bump
github.com/microsoft/go-infrato a newer pseudo-version that supports configuring JUnit naming behavior. - Switch JUnit conversion to
json2junit.NewConverterWithOptionsand enableIncludePackageInTestName.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/_util/go.mod | Updates the go-infra module version to pick up the new json2junit option support. |
| eng/_util/go.sum | Updates checksums corresponding to the go-infra version bump. |
| eng/_util/buildutil/testjson.go | Enables package-qualified test names in generated JUnit output via converter options. |
dagood
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to microsoft/go-infra#445 to enable full package names