fix: preserve currency number format when converting xlsx to markdown#1630
Open
zhaorong566 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: preserve currency number format when converting xlsx to markdown#1630zhaorong566 wants to merge 2 commits intomicrosoft:mainfrom
zhaorong566 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
added 2 commits
March 21, 2026 16:24
- Load workbook with openpyxl to detect number_format on each cell - Convert DataFrame column to object type before assigning formatted string - Supports USD, EUR, JPY, GBP currency symbols Fixes microsoft#53
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the issue where currency-formatted cells in Excel files
lose their formatting (e.g.,
$1,199.00becomes1199.0)when converted to Markdown.
How?
_xlsx_converter.pynumber_formatare now rendered withthe appropriate symbol and decimal places
Test
Before fix:
After fix:
Fixes
Closes #53