Conversation
| return { message, stackLines, location }; | ||
| } | ||
|
|
||
| export function errorLocationFromStack(error: Error | undefined, pathSeparator: string, showInternalStackFrames: boolean = false): { |
There was a problem hiding this comment.
This code works for Node.js (V8), it does not work for errors in WebKit / Firefox.
There was a problem hiding this comment.
The new test passes for all browser. So I am not sure what to do?
There was a problem hiding this comment.
I think we should plumb the location all the way from the browser-specific protocol event to here. It should be already available in the protcol.
There was a problem hiding this comment.
@cpAdm web error originates from the web page. That web page runs in the browser, it can be Firefox or WebKit. You can't parse Firefox error text in Node and assume it is coming from V8 - stack frame format is different.
There was a problem hiding this comment.
Alright, thanks for the feedback!
The error is now plumbed all the way from the browsers. I did need to change the Firefox protocol, so if I understand correctly, this still needs a revision update? But I think that needs to be done via the GitHub workflow?
3 participants
- Sticked with same return type asConsoleMessage.location()Closes: #39687