Place private link resources in shared/org resource groups instead of a dedicated resource group#312
Merged
johnstairs merged 3 commits intomainfrom Apr 20, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating a separate
<rg>-privatelink-<subnetRG>-<vnet>resource group for private endpoints, DNS zones, and VNet links, this change places those resources directly in the existing resource groups — shared resources (Postgres PE, Traefik PE, AKS private DNS zone) go intocloud.resourceGroup, and per-organization resources (storage PEs, org domain DNS zones) go into the org's resource group.This is a breaking change: Existing private-link deployments must delete the legacy
*-privatelink-*resource group before re-deploying. This causes a temporary connectivity outage until the re-deploy recreates the resources in the correct resource groups. AddedcheckNoLegacyPrivateLinkResourceGroups()that detects if the old dedicated resource group still exists and fails with a message instructing the user to delete it first (noting the temporary connectivity outage).Also, I needed to update the GPU SKU that we use, as
Standard_NC6s_v3is no longer available.