Merged
Conversation
Dev -> main
1. Add finewebedu workload. 2. Update num_trials and num_studies to be flag defined (since they can vary between self and external tuning rulesets) 3. Have every run use a different seed for more variability
1. Ensure any variable can be passed in via flags. Folks shouldn't have to edit the file and hardcode variables for any reason. 2. Pass max global steps via a flag. 3. Update some default values for the new submission (repo/image/config file/logs bucket)
The script is meant to be used only in the slurm cluster. It forces a specific directory structure, and checks for it right in the beginning. If the dir structure is not as expected, it throws an error and explains the structure it expects. It also includes a dry run flag which runs the job for 10 steps, and includes a command on how to use it at the top of the file. Also update the readme file to explain this script.
1. Update base workloads to 9 (with finewebedu). 2. Remove all logic related to test targets, since they are no longer used. Work only with validation targets. 3. Fix step time computation.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
1. Fix linter issue in make_job_config 2. Fix typo in docker image creation script 3. Add importlib resources to ensure backwards compatibilty. Without that the tests seem to fail on ModuleNotFoundError.
priyakasimbeg
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating scripts to work well with the new round of submissions (which run on A100) on slurm.