Add client callbacks for list_changed notifications#2281
Open
omar-y-abdi wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
Add client callbacks for list_changed notifications#2281omar-y-abdi wants to merge 3 commits intomodelcontextprotocol:mainfrom
omar-y-abdi wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
The ClientSession._received_notification method silently dropped ToolListChangedNotification, ResourceListChangedNotification, and PromptListChangedNotification. Add optional callback parameters following the existing logging_callback pattern so clients can react when the server signals that its tool, resource, or prompt lists have changed. Github-Issue: modelcontextprotocol#2107
…hods These methods are now exercised by the new list_changed callback tests, so the strict-no-cover CI check rejects the pragma. Github-Issue: modelcontextprotocol#2107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2107.
ClientSession._received_notification silently dropped ToolListChangedNotification, ResourceListChangedNotification, and PromptListChangedNotification via a catch-all pass. This adds optional callback parameters (tools_list_changed_callback, resources_list_changed_callback, prompts_list_changed_callback) following the existing logging_callback pattern, so clients can react when the server signals that its tool, resource, or prompt lists have changed.
Changes: