Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughCI workflows were updated to install the Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as GitHub Actions Runner
participant Rust as setup-rust (toolchain + clippy)
participant Mold as setup-mold (rui314/setup-mold@v1)
participant Cache as actions/cache
participant Cargo as Cargo (build/check/test)
Runner->>Rust: install Rust toolchain (+clippy)
Runner->>Mold: install mold linker
Runner->>Cache: restore cache
Runner->>Cargo: run `cargo check` / `cargo clippy` / `cargo test`
Cargo-->>Cache: update cache
Cargo-->>Runner: report results
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chengwenxi
left a comment
There was a problem hiding this comment.
LGTM. Clean integration of mold linker via rui314/setup-mold@v1 in build/clippy/test jobs. -C link-arg=-fuse-ld=mold is the correct RUSTFLAGS approach. fmt/doc-test exclusion is reasonable.
Install mold via rui314/setup-mold and pass -C link-arg=-fuse-ld=mold via RUSTFLAGS in build, clippy, and test jobs. Mold is a multi-threaded linker that significantly speeds up the linking phase compared to the default single-threaded ld. fmt and doc-test jobs are excluded as they don't produce linked binaries.
ce8abcd to
271b27f
Compare
RUSTFLAGS is set globally so all jobs that compile need mold installed.
- Replace `cargo build --all` (debug) + `cargo build --all --release` with `cargo check --all --all-targets` - cargo check only does type-checking without producing binaries, ~4x faster while still catching compilation errors and warnings - Release builds should only happen in release workflow, not PR CI - Remove unnecessary rustfmt/clippy components from build job (those are installed in the lint workflow)
Summary
rui314/setup-moldin build, clippy, and test jobs-C link-arg=-fuse-ld=moldvia RUSTFLAGS to use mold instead of default single-threadedldBoth scroll-reth and tempo use mold in CI for faster builds.
Test plan
Summary by CodeRabbit