Skip to content

MOSIP-44709: Fixed HealthCheck module mapping by using normalized module name instead of prefixed identifier.#1350

Open
SradhaMohanty5899 wants to merge 6 commits intomosip:developfrom
SradhaMohanty5899:MOSIP-44709-temp
Open

MOSIP-44709: Fixed HealthCheck module mapping by using normalized module name instead of prefixed identifier.#1350
SradhaMohanty5899 wants to merge 6 commits intomosip:developfrom
SradhaMohanty5899:MOSIP-44709-temp

Conversation

@SradhaMohanty5899
Copy link
Copy Markdown
Contributor

@SradhaMohanty5899 SradhaMohanty5899 commented Apr 16, 2026

Fixes HealthCheck module mismatch by replacing the prefixed module name (BaseTestCase.currentModule) with a normalized value (GlobalConstants.MASTERDATA), ensuring correct mapping with healthCheckEndpoint.properties and proper endpoint filtering.

Summary by CodeRabbit

  • Refactor

    • Updated health monitoring module tracking in test infrastructure.
  • Chores

    • Adjusted startup notification banner formatting.

Signed-off-by: Sradha Mohanty <mohantysradha10@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@SradhaMohanty5899 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 15 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 41 minutes and 15 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 89650274-fa93-4e41-bee4-2fd8466b4fe9

📥 Commits

Reviewing files that changed from the base of the PR and between e869229 and 21e7a63.

📒 Files selected for processing (1)
  • api-test/src/main/java/io/mosip/testrig/apirig/masterdata/testrunner/MosipTestRunner.java

Walkthrough

The startup banner string in MosipTestRunner was reformatted with reduced leading characters. Additionally, the HealthChecker thread initialization was modified to use GlobalConstants.MASTERDATA instead of BaseTestCase.currentModule when setting the current running module.

Changes

Cohort / File(s) Summary
Startup and Health Check Configuration
api-test/src/main/java/io/mosip/testrig/apirig/masterdata/testrunner/MosipTestRunner.java
Adjusted startup banner formatting and modified HealthChecker thread initialization to use GlobalConstants.MASTERDATA for module tracking instead of the previous module reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The banner shrinks, the module shifts with grace,
Health checks now know their proper place!
Constants guide the way so bright,
A startup message set just right! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific fix: replacing a prefixed module identifier with a normalized module name for HealthCheck module mapping. It accurately reflects the main change in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Sradha Mohanty <mohantysradha10@gmail.com>
Signed-off-by: Sradha Mohanty <mohantysradha10@gmail.com>
Signed-off-by: Sradha Mohanty <mohantysradha10@gmail.com>
Signed-off-by: Sradha Mohanty <mohantysradha10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants