Skip to content

Adding Display ratio#137

Open
adragnevVW wants to merge 10 commits intomasterfrom
Feature/Adding-Ratio-support-to-Display
Open

Adding Display ratio#137
adragnevVW wants to merge 10 commits intomasterfrom
Feature/Adding-Ratio-support-to-Display

Conversation

@adragnevVW
Copy link
Copy Markdown
Collaborator

No description provided.

@adragnevVW
Copy link
Copy Markdown
Collaborator Author

This is a refresh of #108

@adragnevVW adragnevVW self-assigned this Jan 21, 2026
@AndriiVoitenko
Copy link
Copy Markdown
Collaborator

But I still have the same doubts as in this comment: #108 (comment)

@adragnevVW
Copy link
Copy Markdown
Collaborator Author

Hi @ILane-VW & @AndriiVoitenko,
I've updated the way we export display ratios by adding width (unsigned int), height (unsigned int), and aspect ratio (double).
This change allows us to export generic display ratios in a more precise and flexible way. Storing width and height preserves the exact ratio (like 3:4 or 16:9), while the double aspect ratio provides a ready-to-use numeric value for calculations and comparisons. Using unsigned integers ensures no negative values.

@AndriiVoitenko
Copy link
Copy Markdown
Collaborator

AndriiVoitenko commented Mar 26, 2026

Hi @adragnevVW,

and what about synchronization? I mean in the end of the day display has only one aspect ration. And currently user can specify width 4, height 3 and ratio 1,7777, mean and depending on which API he will call, the result will be different for the same object.

Therefore it is not a good idea to duplicate data. Sure you can provide 2 API, but internally store only one set of data, for example as we discussed on Friday: store 2 integers and by requesting of double calculate it.

Beside that, we still do not have it in a specification, so you should not merge it to the library until new version of specification posted + IsCurved new property, right? This one should be also addressed by specification group.

Copy link
Copy Markdown
Collaborator

@AndriiVoitenko AndriiVoitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see on conversation page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants