-
Notifications
You must be signed in to change notification settings - Fork 2
docs(auth): align front-door flows with shipped workflows #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: git-plan/05-settings-productization
Are you sure you want to change the base?
Changes from all commits
f9482b4
089dff2
0c88b88
9ba069b
36a0a37
b7b629a
fae70ee
1e0c41c
04491c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,10 @@ export function isNonInteractiveMode(): boolean { | |
| return false; | ||
| } | ||
|
|
||
| export function isInteractiveLoginMenuAvailable(): boolean { | ||
| return !isNonInteractiveMode() && isTTY(); | ||
| } | ||
|
Comment on lines
+29
to
+31
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial minor: redundant tty check.
this may be intentional defense-in-depth if 🤖 Prompt for AI Agents |
||
|
|
||
| export async function promptAddAnotherAccount( | ||
| currentCount: number, | ||
| ): Promise<boolean> { | ||
|
|
@@ -251,7 +255,7 @@ export async function promptLoginMode( | |
| return { mode: "add" }; | ||
| } | ||
|
|
||
| if (!isTTY()) { | ||
| if (!isInteractiveLoginMenuAvailable()) { | ||
| return promptLoginModeFallback(existingAccounts); | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarify that startup recovery prompt is interactive-only
the workflow text implies this always appears, but the code gates it behind interactive login mode (
lib/codex-manager.ts:4373). please call out tty/interactive requirement here to match shipped behavior.As per coding guidelines
docs/**: keep README, SECURITY, and docs consistent with actual CLI flags and workflows. whenever behavior changes, require updated upgrade notes and mention new npm scripts.🤖 Prompt for AI Agents