fix(k8s): ClusterIP resolution, manual persistence, safe Service cleanup#95
Merged
oleksandr-nc merged 6 commits intomainfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
fix/k8s-manual-expose-persistence
branch
from
c8407a1 to
99bed2c
Compare
kyteinsky
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During writing CI tests for Ks in AppAPI found some bugs and resolved them:
spec.clusterIPinstead of DNS name for ClusterIP Service resolution - DNS names only resolve inside the cluster but HaRP often runs outside (Docker on host)managed-by=harplabel on ExApp removal - preserves operator-managed Services (manual expose)Succeededphase as successful start inwaitExAppStart- fixes race condition with init-only apps (e.g. app-skeleton-python) that exit before the readiness check runsexpose_typechanged fromnodeporttoclusteripto match Kubernetes standardhttps://github.com/nextcloud/app_api/actions/runs/23335605674?pr=783
https://github.com/nextcloud/app_api/actions/runs/23335605697?pr=783
https://github.com/nextcloud/app_api/actions/runs/23335605711?pr=783