Skip to content

chore(tests): check Snowflake ID preserved in 32 bits #58892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Altahrim wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(tests): check Snowflake ID preserved in 32 bits #58892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions tests/lib/Preview/PreviewMapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,25 @@ public function testGetAvailablePreviews(): void {
// No preview available
$this->assertEquals([42 => []], $this->previewMapper->getAvailablePreviews([42]));

$this->createPreviewForFileId(42);
$previewId = $this->createPreviewForFileId(42);
$previews = $this->previewMapper->getAvailablePreviews([42]);
$this->assertNotEmpty($previews[42]);
$this->assertNull($previews[42][0]->getLocationId());
$this->assertNull($previews[42][0]->getBucketName());
$this->assertNull($previews[42][0]->getObjectStoreName());
# Check that Snowflake ID is preserved, even in 32 bits
$this->assertEquals($previews[42][0]->getId(), $previewId);

$this->createPreviewForFileId(43, 2);
$previewId = $this->createPreviewForFileId(43, 2);
$previews = $this->previewMapper->getAvailablePreviews([43]);
$this->assertNotEmpty($previews[43]);
$this->assertEquals('preview-2', $previews[43][0]->getBucketName());
$this->assertEquals('default', $previews[43][0]->getObjectStoreName());
# Check that Snowflake ID is preserved, even in 32 bits
$this->assertEquals($previews[43][0]->getId(), $previewId);
}

private function createPreviewForFileId(int $fileId, ?int $bucket = null): void {
private function createPreviewForFileId(int $fileId, ?int $bucket = null): string {
$locationId = null;
if ($bucket) {
$qb = $this->connection->getQueryBuilder();
Expand Down Expand Up @@ -95,5 +99,7 @@ private function createPreviewForFileId(int $fileId, ?int $bucket = null): void
$preview->setLocationId($locationId);
}
$this->previewMapper->insert($preview);

return $preview->id;
}
}
Loading