Open
Conversation
tnotheis
requested changes
Mar 23, 2026
packages/runtime/src/useCases/consumption/openid4vc/VerifyPresentationToken.ts
Outdated
Show resolved
Hide resolved
tnotheis
requested changes
Mar 27, 2026
packages/runtime/src/useCases/consumption/openid4vc/VerifyPresentationToken.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Adds runtime support to verify verifiable presentation “presentation tokens” (SD-JWT-based) and uses that verification to decide whether the app UI should treat a received presentation token as valid.
Changes:
- Introduce
VerifyPresentationTokenuse case + schema, expose it via the runtimeOpenId4VcFacade. - Add holder/controller verification plumbing in
@nmshd/consumptionand extend runtime tests for verification outcomes. - Update
AppStringProcessorand its tests to verify presentation tokens and add local Eudiplo dev/test container assets.
Reviewed changes
Copilot reviewed 13 out of 22 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.eslint.json | Includes .dev/eudiplo in ESLint TS project scope. |
| packages/runtime/test/consumption/openid4vc.test.ts | Adds tests for creating and verifying presentation tokens, including negative cases. |
| packages/runtime/src/useCases/consumption/openid4vc/index.ts | Exports the new verify use case. |
| packages/runtime/src/useCases/consumption/openid4vc/VerifyPresentationToken.ts | New use case to verify presentation token content against an expected nonce. |
| packages/runtime/src/useCases/common/Schemas.ts | Adds JSON schema for VerifyPresentationTokenRequest. |
| packages/runtime/src/extensibility/facades/consumption/OpenId4VcFacade.ts | Exposes verifyPresentationToken() on the facade. |
| packages/consumption/src/modules/openid4vc/local/Holder.ts | Adds holder-side verification via SdJwtVcApi.verify(). |
| packages/consumption/src/modules/openid4vc/OpenId4VcController.ts | Exposes holder verification via controller method. |
| packages/app-runtime/test/runtime/AppStringProcessor.test.ts | Updates test to obtain a real presentation token via Eudiplo and process its URL. |
| packages/app-runtime/src/AppStringProcessor.ts | Calls verify API and passes validity flag to showVerifiablePresentation. |
| .dev/eudiplo/startEudiplo.ts | Adds a testcontainer helper to run Eudiplo with local config. |
| .dev/eudiplo/config/test/presentation/test.json | Adds Eudiplo presentation config fixture. |
| .dev/eudiplo/config/test/keys/key.json | Adds Eudiplo key fixture. |
| .dev/eudiplo/config/test/issuance/issuance.json | Adds Eudiplo issuance config fixture. |
| .dev/eudiplo/config/test/issuance/credentials/test.json | Adds Eudiplo credential config fixture. |
| .dev/eudiplo/config/test/info.json | Adds Eudiplo tenant info fixture. |
| .dev/eudiplo/config/test/images/logo.png | Adds Eudiplo logo fixture used in displays. |
| .dev/eudiplo/config/test/clients/test-admin.json | Adds Eudiplo client fixture for tests. |
| .dev/eudiplo/config/test/certs/certificate.json | Adds Eudiplo certificate fixture. |
| .dev/compose.openid4vc.yml | Updates volume mount path for Eudiplo config assets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/runtime/src/useCases/consumption/openid4vc/VerifyPresentationToken.ts
Show resolved
Hide resolved
…into verify-presentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist