feat: use JSON, templates, npx, and add dry-run support#186
Draft
avivkeller wants to merge 3 commits intonodejs:mainfrom
Draft
feat: use JSON, templates, npx, and add dry-run support#186avivkeller wants to merge 3 commits intonodejs:mainfrom
avivkeller wants to merge 3 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3
Closes #185
This PR makes a few substantial changes to improve the DX of this tool.
templates/to JSON configurations inconfigs/, this'll make it easier to edit and parse (See fix(properties): allow quote-less props #185 for an example of dotenv struggles)--dry-runargument, as, when testing this, it's important not to create the issues and notesnpx-style support. (i.e.npx . tscornpx https://github.com/nodejs/create-node-meeting-artifacts tscsrc/, since it no longer really needs to be easily accessible for scripts, it'll benpx-ed.The goal here is:
For example, running
npx . web --dry-runproduces: