Skip to content

fix: modify update.sh script #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MikeMcC399 wants to merge 1 commit into from
+12 −21
Closed

fix: modify update.sh script #2414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 12 additions & 21 deletions update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,21 @@ function usage() {
$0 [-s] [MAJOR_VERSION(S)] [VARIANT(S)]

Examples:
- update.sh # Update all images
- update.sh -s # Update all images, skip updating Alpine and Yarn
- update.sh 8,10 # Update all variants of version 8 and 10
- update.sh -s 8 # Update version 8 and variants, skip updating Alpine and Yarn
- update.sh 8 alpine # Update only alpine's variants for version 8
- update.sh -s 8 bullseye # Update only bullseye variant for version 8, skip updating Alpine and Yarn
- update.sh . alpine # Update the alpine variant for all versions
- update.sh # Update all images
- update.sh 24 # Update all variants of version 24
- update.sh 22,24 # Update all variants of version 22 and 24
- update.sh 24 alpine3.23 # Update only alpine3.23's variants for version 24
- update.sh 24 trixie,trixie-slim # Update only trixie & trixie-slim variants for version 24
- update.sh . trixie # Update the trixie variant for all versions

OPTIONS:
-s Security update; skip updating the yarn and alpine versions.
-b CI config update only
-h Show this message

EOF
}

SKIP=false
while getopts "sh" opt; do
while getopts "h" opt; do
case "${opt}" in
s)
SKIP=true
shift
;;
h)
usage
exit
Expand Down Expand Up @@ -65,9 +57,7 @@ fi
# TODO: Should be able to specify target architecture manually
arch=$(get_arch)

if [ "${SKIP}" != true ]; then
yarnVersion="$(curl -sSL --compressed https://yarnpkg.com/latest-version)"
fi
yarnVersion="$(curl -sSL --compressed https://yarnpkg.com/latest-version)"

function in_versions_to_update() {
local version=$1
Expand Down Expand Up @@ -134,6 +124,9 @@ function update_node_version() {
sed -Ei -e 's/^FROM (.*)/FROM '"$fromprefix"'\1/' "${dockerfile}-tmp"
sed -Ei -e 's/^(ENV NODE_VERSION)=.*/\1='"${nodeVersion}"'/' "${dockerfile}-tmp"

currentYarnVersion="$(grep "ENV YARN_VERSION" "${dockerfile}" | cut -d'=' -f2)"
sed -Ei -e 's/^(ENV YARN_VERSION=).*/\1'"${currentYarnVersion}"'/' "${dockerfile}-tmp"

# shellcheck disable=SC1004
new_line=' \\\
'
Expand Down Expand Up @@ -168,9 +161,7 @@ function update_node_version() {
if diff -q "${dockerfile}-tmp" "${dockerfile}" > /dev/null; then
echo "${dockerfile} is already up to date!"
else
if [ "${SKIP}" != true ]; then
sed -Ei -e 's/^(ENV YARN_VERSION)=.*/\1='"${yarnVersion}"'/' "${dockerfile}-tmp"
fi
sed -Ei -e 's/^(ENV YARN_VERSION=).*/\1'"${yarnVersion}"'/' "${dockerfile}-tmp"
echo "${dockerfile} updated!"
fi

Expand Down