Skip to content

http: make maximum header size configurable per-stream or per-server#30570

Closed
addaleax wants to merge 4 commits intonodejs:masterfrom
addaleax:http-max-header-size-configurable
Closed

http: make maximum header size configurable per-stream or per-server#30570
addaleax wants to merge 4 commits intonodejs:masterfrom
addaleax:http-max-header-size-configurable

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Nov 20, 2019

Make maxHeaderSize a.k.a. --max-header-size configurable now that
the legacy parser is gone (which only supported a single global value).

Refs: #30567

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+3 more reviewers

@sam-github sam-github sam-github approved these changes

@devnexen devnexen devnexen approved these changes

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http Issues or PRs related to the http subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@addaleax @mcollina @nodejs-github-bot @sam-github @jasnell @cjihrig @devnexen @lundibundi @targos