Skip to content

test: avoid flaky restart sync in debugger exceptions test#62055

Open
inoway46 wants to merge 2 commits intonodejs:mainfrom
inoway46:fix-flaky-test-debugger-exceptions
Open

test: avoid flaky restart sync in debugger exceptions test#62055
inoway46 wants to merge 2 commits intonodejs:mainfrom
inoway46:fix-flaky-test-debugger-exceptions

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented Mar 1, 2026

In test/parallel/test-debugger-exceptions.js, using stepCommand('r') can intermittently time out while waiting for BREAK_MESSAGE. This PR preserves the test intent, but changes the reconnect sync point for r to wait for ok before waitForInitialBreak().

Same approach as #62807

CI logs

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions parallel/test-debugger-exceptions
  • ./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-exceptions
  • ./tools/test.py -p actions parallel/test-debugger-restart-message parallel/test-debugger-run-after-quit-restart
  • CI passes on macOS

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 1, 2026
@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch from 217a40b to bfe5f1b Compare March 1, 2026 04:18
@inoway46 inoway46 marked this pull request as ready for review March 1, 2026 04:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (58a8e1d) to head (1b3d3fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62055      +/-   ##
==========================================
- Coverage   89.69%   89.68%   -0.01%     
==========================================
  Files         706      706              
  Lines      218222   218222              
  Branches    41768    41771       +3     
==========================================
- Hits       195731   195711      -20     
- Misses      14411    14418       +7     
- Partials     8080     8093      +13     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2026
@nodejs-github-bot

This comment was marked as outdated.

@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch 2 times, most recently from 64b5b0e to a3aa5ce Compare March 28, 2026 04:53
@cola119 cola119 added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Mar 29, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@inoway46
Copy link
Copy Markdown
Contributor Author

Since the Windows flakiness seems better now, could you please rerun CI for this PR?

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@inoway46

This comment was marked as outdated.

@inoway46
Copy link
Copy Markdown
Contributor Author

https://ci.nodejs.org/job/node-test-commit-windows-fanned/76495/console
It looks like this failure happened around git-rebase and the temp-ref handoff, possibly due to a race while the downstream job was trying to read the temp ref. Could someone please rerun CI for this PR?

I'm not sure this will help, but rebasing this branch onto the latest upstream/main may reduce the chance of this. If the next rerun fails again, I'll rebase onto upstream/main and force-push.

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch 2 times, most recently from c5ad00e to 27e3713 Compare April 19, 2026 04:31
@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch from 27e3713 to 1b3d3fe Compare April 19, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants