[v22.x backport] lib: backport _tls_common and _tls_wrap refactors#62231
Open
aduh95 wants to merge 1 commit intonodejs:v22.x-stagingfrom
Open
[v22.x backport] lib: backport _tls_common and _tls_wrap refactors#62231aduh95 wants to merge 1 commit intonodejs:v22.x-stagingfrom
_tls_common and _tls_wrap refactors#62231aduh95 wants to merge 1 commit intonodejs:v22.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
This is the same as the original change, minus the `process.emitWarning`
calls and unit tests that expect the deprecation warnings.
Original commit message:
lib: deprecate _tls_common and _tls_wrap
runtime deprecate the _tls_common and _tls_wrap
modules, users should use nust node:tls insteal
and internally internal/tls/commond and
internal/tls/wrap should be used instead
PR-URL: nodejs#57643
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
aduh95
force-pushed
the
backport-tls-refactor
branch
from
c1d364a to
6bc7a51
Compare
Collaborator
aduh95
changed the title
_tls_common and _tls_wrap refactors_tls_common and _tls_wrap refactors
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as the original change (#57643, #61044), minus the
process.emitWarningcalls and unit tests that expect the deprecation warnings