doc: clarify process._debugProcess() in Permission Model#62537
Conversation
|
Review requested:
|
|
Thanks for catching that — I've updated the sentence to remove the |
Commit Queue failed- Loading data for nodejs/node/pull/62537 ✔ Done loading data for nodejs/node/pull/62537 ----------------------------------- PR info ------------------------------------ Title doc: clarify that process._debugProcess() is not restricted by the Permission Model (#62537) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cybe4sent1nel:doc/permission-model-debugprocess-clarification -> nodejs:main Labels doc, author ready Commits 3 - doc: clarify process._debugProcess() is not gated by kInspector - Update doc/api/permissions.md - Update permissions.md for V8 Inspector access Committers 2 - cybe4sent1nel <fahadkhanxyz8816.@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/62537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 01 Apr 2026 14:32:02 GMT ✔ Approvals: 1 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/62537#pullrequestreview-4050421568 ✘ This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval) ⚠ GitHub cannot link the author of 'doc: clarify process._debugProcess() is not gated by kInspector' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/23950275911 |
6729b80 to
3a21809
Compare
|
Can you please remove the merge commit? |
1d3c070 to
ccd9ce2
Compare
|
@lpinca I've rebased and removed the merge commit as requested! The history is clean now. |
24f8c0d to
ea5c6bc
Compare
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
|
Now that the 120-hour waiting period has officially passed, I noticed the commit-queue bot is skipping this PR because it currently only has the commit-queue-squash label. Could you please re-add the primary commit-queue label? Without that specific trigger label, the get_mergeable_prs script isn't picking this up for the landing sequence. Thank you! |
|
Landed in 95dee4f |
What
Adds a documentation note to the Permission Model page clarifying that
process._debugProcess()is not restricted by thekInspectorpermission scope or any other Permission Model scope.
Why
The Permission Model documentation lists "Inspector protocol" as a
restricted surface. A developer reading this reasonably expects that
--permissionprevents all Inspector activation — includingcross-process activation via
process._debugProcess().The current behavior creates a silent inconsistency:
kInspectorblocks the sandboxed process from opening its ownInspector.
kInspectordoes not block the sandboxed process from callingprocess._debugProcess(pid)to force another Node.js process toopen its Inspector.
This gap is not documented anywhere. This note ensures developers are
not surprised by this behavior when they rely on the Permission Model
as a sandbox.
Behavior unchanged
This is a documentation-only change. No API behavior is modified.
Background
Discussed with @RafaelGSS. The behavior is consistent with the Node.js
threat model (Node.js trusts the OS environment it runs in, and
cross-process signaling is an OS-level capability). The fix here is
documentation so operators understand what responsibility falls on them
vs. the Permission Model.
Checklist
make lintpasses