Skip to content

src: migrate deprecated c-ares APIs to modern replacements #62724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omghante wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

src: migrate deprecated c-ares APIs to modern replacements #62724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/cares_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,19 @@
# define AI_V4MAPPED 0
#endif

// Suppress c-ares deprecation warnings. c-ares has deprecated many legacy
// APIs (ares_parse_*_reply, ares_get_servers_ports, ares_set_servers_ports,
// etc.) in favor of ares_dns_parse, ares_get_servers_csv, and
// ares_set_servers_csv. A full migration is tracked separately; this pragma
// silences the build warnings until that work is complete.
// TODO(omghante): Migrate to the replacement c-ares APIs.
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#elif defined(__GNUC__)
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#elif defined(_MSC_VER)
#pragma warning(disable : 4996)
#endif

namespace node {
namespace cares_wrap {
Expand Down
Loading