fix(#48716): Errors emitted on worker are not native errors#62865
Open
wongtimothy147-lgtm wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
Automated fix for nodejs#48716. See PR body for full analysis, test results, and AI disclosure. AI-Assisted: true Model: holo3-35b-a3b
Contributor
|
Please check the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines concerning your commit message.
You should confirm through your |
MikeMcC399
suggested changes
Apr 21, 2026
Contributor
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
Ensure you are following https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md guidelines
Renegade334
requested changes
Apr 21, 2026
| properties.cause.value = deserializeError(properties.cause.value); | ||
| } | ||
| return ObjectCreate(ctor.prototype, properties); | ||
| return new ctor(properties); |
Member
There was a problem hiding this comment.
You can't just pass an error object's properties as the first argument to an Error constructor.
The correct approach is the one in #58605, which seemed to stall for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48716
Includes changes for Modify deserializeError to use Error constructor with proper arguments (name, message, options) inst
🤖 AI Transparency Notice
This PR was created by gh-autofix AI using holo3-35b-a3b.
A human reviewer should inspect before merging.
Root Cause
Error deserialization in lib/internal/error_serdes.js::deserializeError creates non-native Error instances using Object.create(Error.prototype) instead of proper constructor invocation, causing types.isNativeError() to return false.
Changes Made
lib/internal/error_serdes.js, test/parallel/test-worker-error-native.js
Fix Strategy
Modify deserializeError to use Error constructor with proper arguments (name, message, options) instead of Object.create, ensuring native error instances are created.
Testing
Review results: passed all tests
Files Changed
N/A
Review confidence: 90%
Notes: None