Skip to content

fix(#46221): RequestInit: duplex option is required when sending a body #62869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wongtimothy147-lgtm wants to merge 1 commit into from
+19 −0
Closed

fix(#46221): RequestInit: duplex option is required when sending a body #62869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/undici/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
const { test } = require('tap')
const { Request } = require('../lib/undici/request')
const { Readable } = require('stream')

test('Request with ReadableStream body requires duplex option', (t) => {
t.plan(2)

const stream = new Readable({
read () {}
})

t.throws(() => {
new Request('http://example.com', { body: stream })
}, TypeError, 'should throw when duplex is missing')

t.doesNotThrow(() => {
new Request('http://example.com', { body: stream, duplex: 'auto' })
}, 'should not throw when duplex is provided')
})
Loading