Skip to content

lib: harden kKeyOps lookup with null prototype#62877

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:lib-kkeyops-lookup
Open

lib: harden kKeyOps lookup with null prototype#62877
panva wants to merge 1 commit intonodejs:mainfrom
panva:lib-kkeyops-lookup

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 21, 2026

validateKeyOps(['sign', 'toString', 'constructor']) was throwing DataError before when it should instead ignore unrecognized values.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 21, 2026
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.61%. Comparing base (b2248fd) to head (c7294ee).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62877   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         706      706           
  Lines      219144   219166   +22     
  Branches    41985    41999   +14     
=======================================
+ Hits       196391   196413   +22     
+ Misses      14629    14627    -2     
- Partials     8124     8126    +2     
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 95.52% <100.00%> (+0.12%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants