lib: harden kKeyOps lookup with null prototype#62877
Open
panva wants to merge 1 commit intonodejs:mainfrom
Open
lib: harden kKeyOps lookup with null prototype#62877panva wants to merge 1 commit intonodejs:mainfrom
panva wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62877 +/- ##
=======================================
Coverage 89.61% 89.61%
=======================================
Files 706 706
Lines 219144 219166 +22
Branches 41985 41999 +14
=======================================
+ Hits 196391 196413 +22
+ Misses 14629 14627 -2
- Partials 8124 8126 +2
🚀 New features to boost your workflow:
|
Renegade334
approved these changes
Apr 21, 2026
ljharb
approved these changes
Apr 21, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
tniessen
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateKeyOps(['sign', 'toString', 'constructor'])was throwing DataError before when it should instead ignore unrecognized values.