test_runner: add [Symbol.dispose] to mock Timeout class#62879
Closed
HttpGetBinary wants to merge 1 commit intonodejs:mainfrom
Closed
test_runner: add [Symbol.dispose] to mock Timeout class#62879HttpGetBinary wants to merge 1 commit intonodejs:mainfrom
HttpGetBinary wants to merge 1 commit intonodejs:mainfrom
Conversation
The mock Timeout returned by MockTimers did not implement [Symbol.dispose], making it incompatible with the `using` keyword. The real Timeout has this method. This fix adds it, calling globalThis.clearTimeout(this) which routes through the mock's own clearTimeout when mocks are active. Fixes: #62815
Collaborator
|
Review requested:
|
Member
|
Please don't submit PRs against issues that already have open, active PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #62815
The
Timeoutobject returned byMockTimerswas missing[Symbol.dispose], which means code using theusingkeyword withsetTimeoutwould throw when mock timers are active.Fix
Added
[Symbol.dispose]()to theTimeoutclass inmock_timers.js. It callsglobalThis.clearTimeout(this), which — when mocks are active — routes to the mock's own#clearTimeout, matching realTimeoutbehavior.Test