Skip to content

deps: V8: cherry-pick d7b5bc223b8d#62880

Closed
luyahan wants to merge 1 commit intonodejs:v26.xfrom
luyahan:port-71574319
Closed

deps: V8: cherry-pick d7b5bc223b8d#62880
luyahan wants to merge 1 commit intonodejs:v26.xfrom
luyahan:port-71574319

Conversation

@luyahan
Copy link
Copy Markdown
Contributor

@luyahan luyahan commented Apr 22, 2026

deps: V8: cherry-pick d7b5bc223b8d
Original commit message:

[riscv] Fix incorrect check supports_wasm_simd_128

Change-Id: I3ee389a3036fddc6807cef18abea553d3861ad07
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7087478
Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Reviewed-by: Florian Loitsch <floitsch@rivosinc.com>
Reviewed-by: Kasper Lund <kasperl@rivosinc.com>
Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#103365}

Refs: v8/v8@d7b5bc2

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2026
@kxxt
Copy link
Copy Markdown
Member

kxxt commented Apr 22, 2026

This PR fixes nodejs/build#4099 (comment).

CC @nodejs/platform-riscv64

@Renegade334
Copy link
Copy Markdown
Member

This is already included in #61898. Does it need to be backported to existing release lines?

For reference, V8 backports need to follow the process at https://github.com/nodejs/node/blob/main/doc%2Fcontributing%2Fmaintaining%2Fmaintaining-V8.md#backporting-with-git-node-recommended.

@kxxt
Copy link
Copy Markdown
Member

kxxt commented Apr 22, 2026

This is already included in #61898. Does it need to be backported to existing release lines?

No. The bug only affects v26.

Original commit message:

    [riscv] Fix incorrect check supports_wasm_simd_128

    Change-Id: I3ee389a3036fddc6807cef18abea553d3861ad07
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7087478
    Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Reviewed-by: Florian Loitsch <floitsch@rivosinc.com>
    Reviewed-by: Kasper Lund <kasperl@rivosinc.com>
    Auto-Submit: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#103365}

Refs: v8/v8@d7b5bc2
@luyahan
Copy link
Copy Markdown
Contributor Author

luyahan commented Apr 22, 2026

@luyahan luyahan changed the title deps: backport d7b5bc2 from upstream v8 deps: V8: cherry-pick d7b5bc223b8d Apr 22, 2026
@Renegade334
Copy link
Copy Markdown
Member

No. The bug only affects v26.

In which case, this will be superseded by the V8 14.6 update and can be safely closed. πŸ‘

@luyahan
Copy link
Copy Markdown
Contributor Author

luyahan commented Apr 22, 2026

No. The bug only affects v26.

In which case, this will be superseded by the V8 14.6 update and can be safely closed. πŸ‘

Thanks.

@luyahan luyahan closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants