Open
Conversation
Original commit message:
unix: treat futimens() as best-effort in copyfile
futimens() may fail with EPERM on CIFS/SMB shares that do not
support setting timestamps. Since preserving timestamps during
copyfile is best-effort, ignore the return value unconditionally.
Refs: libuv/libuv#4396
Fixes: nodejs#56248
Collaborator
|
Review requested:
|
nodejs-github-bot
added
libuv
lpinca
approved these changes
Apr 22, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Author
|
Failures look unlikely to be related, would someone mind re-running the jobs? 🙏 |
Collaborator
Author
|
Looks like different failures again. Not sure what's going on here. The first one ( The second ( Mac is still pending macos15-x64. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick libuv/libuv@439a54b to fix
uv_fs_copyfile()failing withEPERMon CIFS/SMB mounts. Timestamp preservation is now best-effort, matching the existing treatment offchown()in the same function. I'm also the author of the libuv fix.This is a regression introduced by the libuv 1.49.0 update (Node.js 22.12.0 via #55114), which added timestamp preservation to
uv_fs_copyfile(). Since then,fs.copyFile()/fs.copyFileSync()have failed withEPERMon CIFS/SMB mounts on Linux.The buggy block is the same on
v22.x-stagingandv24.x-staging(both on libuv 1.51.0), solts-watch-v22.xandlts-watch-v24.xare good candidates once this matures.Fixes: #56248
Refs: libuv/libuv#5053
Refs: libuv/libuv#4396