Skip to content

crypto: add guards and adjust tests for BoringSSL#62883

Open
panva wants to merge 3 commits intonodejs:mainfrom
panva:more-boring
Open

crypto: add guards and adjust tests for BoringSSL#62883
panva wants to merge 3 commits intonodejs:mainfrom
panva:more-boring

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 22, 2026

This reduces the number of patches needed to make Node.js compile and test crypto/webcrypto when running linked against BoringSSL (date below)

Version / tag: 0.20260327.0 (dated 2026-03-27)
Source:        https://boringssl.googlesource.com/boringssl
Rev:           refs/tags/0.20260327.0
Nixpkgs pin:   ab72be9733b41190ea34f1422a3e4e243ede7533

Some of the patches have been adapted from these sources:

ncrypto changes are already in / from https://github.com/nodejs/ncrypto/blob/88555cc07e8ffcfdbbab779e86cc6225317ee6ae/include/ncrypto.h#L332-L343 / https://github.com/nodejs/ncrypto/blob/88555cc07e8ffcfdbbab779e86cc6225317ee6ae/src/ncrypto.cpp#L3240-L3248

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.59%. Comparing base (c29a34c) to head (a246642).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_dh.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62883      +/-   ##
==========================================
- Coverage   89.62%   89.59%   -0.04%     
==========================================
  Files         706      706              
  Lines      219165   219180      +15     
  Branches    41989    41997       +8     
==========================================
- Hits       196435   196373      -62     
- Misses      14621    14687      +66     
- Partials     8109     8120      +11     
Files with missing lines Coverage Δ
src/crypto/crypto_cipher.cc 77.43% <ø> (ø)
src/crypto/crypto_context.cc 72.09% <ø> (+0.08%) ⬆️
src/crypto/crypto_rsa.cc 65.65% <ø> (ø)
src/crypto/crypto_util.cc 73.18% <ø> (ø)
src/crypto/crypto_dh.cc 67.59% <0.00%> (-0.21%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants