Skip to content

repl: fix dedup comparing normalized line against raw history#62886

Open
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:fixes-repl
Open

repl: fix dedup comparing normalized line against raw history#62886
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:fixes-repl

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Apr 22, 2026

This ensures consistency in how the REPL history handles duplicate entries.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (3a53447) to head (af5530a).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62886      +/-   ##
==========================================
+ Coverage   89.60%   89.62%   +0.02%     
==========================================
  Files         706      706              
  Lines      219179   219179              
  Branches    41993    41992       -1     
==========================================
+ Hits       196400   196444      +44     
+ Misses      14675    14628      -47     
- Partials     8104     8107       +3     
Files with missing lines Coverage Δ
lib/internal/repl/history.js 93.62% <100.00%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants