Skip to content

ffi: fix FLOAT_32 and FLOAT_64 type constants #62892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
watilde wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

ffi: fix FLOAT_32 and FLOAT_64 type constants #62892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/ffi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ These type names are also exposed as constants on `ffi.types`:
* `ffi.types.UINT_32` = `'uint32'`
* `ffi.types.INT_64` = `'int64'`
* `ffi.types.UINT_64` = `'uint64'`
* `ffi.types.FLOAT_32` = `'float32'`
* `ffi.types.FLOAT_64` = `'float64'`
* `ffi.types.FLOAT_32` = `'f32'`
* `ffi.types.FLOAT_64` = `'f64'`

Pointer-like types (`pointer`, `string`, `buffer`, `arraybuffer`, and
`function`) are all passed through the native layer as pointers.
Expand Down
4 changes: 2 additions & 2 deletions lib/ffi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ const types = ObjectFreeze({
UINT_32: 'uint32',
INT_64: 'int64',
UINT_64: 'uint64',
FLOAT_32: 'float32',
FLOAT_64: 'float64',
FLOAT_32: 'f32',
FLOAT_64: 'f64',
});


Expand Down
4 changes: 2 additions & 2 deletions test/ffi/test-ffi-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ test('ffi.types exports canonical type constants', () => {
UINT_32: 'uint32',
INT_64: 'int64',
UINT_64: 'uint64',
FLOAT_32: 'float32',
FLOAT_64: 'float64',
FLOAT_32: 'f32',
FLOAT_64: 'f64',
};

assert.deepStrictEqual(ffi.types, expected);
Expand Down
Loading