Skip to content

morph: adopt neorpc.GASLimitExceededException#3868

Open
AnnaShaleva wants to merge 3 commits intomasterfrom
fetch-gas-limit-exceeded
Open

morph: adopt neorpc.GASLimitExceededException#3868
AnnaShaleva wants to merge 3 commits intomasterfrom
fetch-gas-limit-exceeded

Conversation

@AnnaShaleva
Copy link
Copy Markdown
Member

@AnnaShaleva AnnaShaleva commented Mar 10, 2026

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.79%. Comparing base (821011f) to head (990b8f8).

Files with missing lines Patch % Lines
pkg/morph/client/notary.go 0.00% 3 Missing ⚠️
pkg/morph/client/client.go 0.00% 1 Missing ⚠️
pkg/morph/client/static.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
+ Coverage   26.77%   26.79%   +0.01%     
==========================================
  Files         677      677              
  Lines       44667    44658       -9     
==========================================
+ Hits        11959    11964       +5     
+ Misses      31594    31581      -13     
+ Partials     1114     1113       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov added the blocked Can't be done because of something label Mar 10, 2026
@AnnaShaleva AnnaShaleva force-pushed the fetch-gas-limit-exceeded branch from 81d2ac1 to f66a6fc Compare March 13, 2026 12:45
@AnnaShaleva AnnaShaleva force-pushed the fetch-gas-limit-exceeded branch from f66a6fc to 57cccc3 Compare March 13, 2026 12:49
@AnnaShaleva AnnaShaleva added dependencies Dealing with project dependencies and removed blocked Can't be done because of something labels Mar 13, 2026
@AnnaShaleva AnnaShaleva marked this pull request as ready for review March 13, 2026 13:18
@AnnaShaleva AnnaShaleva changed the title morph: adopt vm.GASLimitExceeded error morph: adopt neorpc.GASLimitExceededException Mar 13, 2026
Copy link
Copy Markdown
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it can be merged now, 0.118.0+ everywhere.

@AnnaShaleva AnnaShaleva force-pushed the fetch-gas-limit-exceeded branch 2 times, most recently from c5b7623 to 5c8777a Compare March 31, 2026 15:53
@AnnaShaleva AnnaShaleva added the bug Something isn't working label Mar 31, 2026
@AnnaShaleva AnnaShaleva force-pushed the fetch-gas-limit-exceeded branch 2 times, most recently from bd36a2f to 0f6e7f7 Compare March 31, 2026 15:57
FAULTed invocations or fallback transaction executions do not suit us.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva force-pushed the fetch-gas-limit-exceeded branch from 0f6e7f7 to 122e82c Compare March 31, 2026 16:03
Fallback transaction should always be awaited along with the main one,
otherwise awaiting will take too long and may end up in an unexpected
retry.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva force-pushed the fetch-gas-limit-exceeded branch from 122e82c to 990b8f8 Compare March 31, 2026 16:26
@AnnaShaleva AnnaShaleva added this to the v0.52.1 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Dealing with project dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants