Draft
Conversation
cthulhu-rider
force-pushed
the
head-proxy-bin
branch
from
bfce35e to
41b24e5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3877 +/- ##
==========================================
- Coverage 26.78% 26.66% -0.13%
==========================================
Files 677 682 +5
Lines 44616 45370 +754
==========================================
+ Hits 11952 12097 +145
- Misses 31553 32147 +594
- Partials 1111 1126 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
head-proxy-bin
branch
7 times, most recently
from
d86d087 to
3f4842f
Compare
Previously, SN decoded another SN's response into intermediate structures and then re-encoded the response from them. This led to unnecessary allocations and processing delays. Now same response buffer is reused to respond to the client. Refs #3898. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This makes HEAD server to not unmarshal `protoobject.HeadResponse` structure from protobuf but iterate over its fields. Only `body` and `meta_header` fields are handled specifically, others are just verified (keeping forward compatibility). Both body and meta header are still unmarshalled for now. In the future they can be optimized the same. Refs #3898. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This makes HEAD server to not unmarshal `protosession.ResponseMetaHeader` structure from protobuf but iterate over its fields. Only `code` field is handled specifically, others are just verified (keeping forward compatibility). Refs #3898. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This makes HEAD server to not unmarshal `protoobject.HeadResponse_Body` structure from protobuf but iterate over its fields. Both header and split info fields are still unmarshalled for now. In the future they can be optimized the same. Refs #3898. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This makes HEAD server to not unmarshal `protoobject.HeadResponse_Body_SplitInfo` structure from protobuf but iterate over its fields. Refs #3898. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Prepare for optimizations. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This makes HEAD server to not unmarshal `protoobject.HeaderWithSignature` structure from protobuf but iterate over its fields. Refs #3898. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
head-proxy-bin
branch
from
3f4842f to
72a5662
Compare
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.