Skip to content

policer: drop duplicate shard copies after relocation#3908

Merged
roman-khimov merged 1 commit intomasterfrom
policer-drop-duplicates
Apr 1, 2026
Merged

policer: drop duplicate shard copies after relocation#3908
roman-khimov merged 1 commit intomasterfrom
policer-drop-duplicates

Conversation

@End-rey
Copy link
Copy Markdown
Contributor

@End-rey End-rey commented Mar 25, 2026

Closes #2087.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.79%. Comparing base (00ad203) to head (b97d91b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/local_object_storage/engine/delete.go 0.00% 25 Missing ⚠️
pkg/services/policer/check.go 66.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3908      +/-   ##
==========================================
+ Coverage   26.78%   26.79%   +0.01%     
==========================================
  Files         677      677              
  Lines       44667    44708      +41     
==========================================
+ Hits        11963    11979      +16     
- Misses      31590    31615      +25     
  Partials     1114     1114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog.

@End-rey End-rey force-pushed the policer-drop-duplicates branch 2 times, most recently from 41a35da to a1b932d Compare March 27, 2026 15:38
@End-rey End-rey force-pushed the policer-drop-duplicates branch from a1b932d to 375d618 Compare April 1, 2026 13:08
Use shard IDs from local listing to keep only the HRW-preferred local copy and
mark redundant copies on other shards as garbage.

Closes #2087.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@End-rey End-rey force-pushed the policer-drop-duplicates branch from 375d618 to b97d91b Compare April 1, 2026 13:25
@End-rey End-rey requested a review from roman-khimov April 1, 2026 13:26
@roman-khimov roman-khimov merged commit 7faca4f into master Apr 1, 2026
22 checks passed
@roman-khimov roman-khimov deleted the policer-drop-duplicates branch April 1, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After replication of object to another shard, the object remains on the returned disk forever

2 participants