Check if the user is in the side window when deleting/renaming#39
Open
gorbit99 wants to merge 2 commits intonvzone:mainfrom
Open
Check if the user is in the side window when deleting/renaming#39gorbit99 wants to merge 2 commits intonvzone:mainfrom
gorbit99 wants to merge 2 commits intonvzone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed, that the way "get_buf_on_cursor" was implemented, it didn't care if the currently active window was the side window. This PR adds a check for this and returns nil otherwise.
Additionally I added in a failsafe to "edit_name" and "delete_term". Previously if these were triggered from the terminal window (and not from the side window), the above bug caused the wrong terminal to be renamed/deleted. I've added a helper function that either returns the selected row if the user is in the side window, or the currently active terminal.
I wanted to control the plugin entirely from the terminal window, never exiting to the sidebar, that's how I ran into this issue.