Skip to content

fix: update redis image reference to use proper docker io location#876

Merged
Skarlso merged 3 commits intoopen-component-model:mainfrom
Skarlso:fix-e2e-image-reference
Mar 30, 2026
Merged

fix: update redis image reference to use proper docker io location#876
Skarlso merged 3 commits intoopen-component-model:mainfrom
Skarlso:fix-e2e-image-reference

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Mar 30, 2026

On-behalf-of: Gergely Brautigam gergely.brautigam@sap.com

What this PR does / why we need it

Fixes open-component-model/ocm-project#974

Which issue(s) this PR is related to

@Skarlso Skarlso requested a review from a team as a code owner March 30, 2026 05:58
frewilhelm
frewilhelm previously approved these changes Mar 30, 2026
@frewilhelm
Copy link
Copy Markdown
Contributor

any idea why it stopped working?

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Mar 30, 2026

@frewilhelm It's a hunch right now. :D There was a change in docker hub that looks like it's affecting some things with regards to how it resolves access. Let's see if this works or not. :)

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Mar 30, 2026

    main_test.go:110: failed to modify component version: cannot determine digest: oci artifact "failed to resolve manifest "docker.io/library/redis:6.0.1": HEAD "https://registry-1.docker.io/v2/library/redis/manifests/6.0.1": GET "https://auth.docker.io/token?scope=repository%3Alibrary%2Fredis%3Apull&service=registry.docker.io": response status code 403: Forbidden" is unknown

Nope. :)

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Mar 30, 2026

Ah... it is that.... docker hub old version is no longer accessible. Just need to update the version to latest.

Because of their licensing changes.

Hmmm... nope.

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Mar 30, 2026

Ah I found it. I'll try to implement a fix.

@frewilhelm frewilhelm self-requested a review March 30, 2026 06:28
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Mar 30, 2026

FUCK! The signing and verification also wants/needs access and I don't want to set up an ocmconfig with tokens and credentials and whatnot. I will just rip out redis from podinfo.

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Mar 30, 2026

Okay, done. Podinfo will no longer deploy and need redis.

@Skarlso Skarlso merged commit 2caa43b into open-component-model:main Mar 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ocm-controller (v1) e2e tests are failing

3 participants